PXP-11291 - Fix/data import directory notice #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
AlbertSnows
commented
Mar 28, 2024
datasimulator/main.py
Outdated
Comment on lines
148
to
149
| if not path_exists: | ||
| logger.error("Cannot create file because path does not exist. Did you create a 'test-data' folder?") |
There was a problem hiding this comment.
i think a better solution in terms of UX would be to create the directory automatically instead
There was a problem hiding this comment.
I suggested that as well but @k-burt-uch is of the mind that we should just handle the error a bit more gracefully.
fix(improvement): generalizing error message Co-authored-by: Pauline Ribeyre <4224001+paulineribeyre@users.noreply.github.com>
fix(rename): better function name Co-authored-by: Pauline Ribeyre <4224001+paulineribeyre@users.noreply.github.com>
…' into fix/data_import_directory_notice # Conflicts: # datasimulator/file_handling.py
k-burt-uch
requested changes
Mar 29, 2024
k-burt-uch
requested changes
Mar 29, 2024
k-burt-uch
reviewed
Mar 29, 2024
k-burt-uch
approved these changes
Apr 1, 2024
paulineribeyre
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check that the directory exists, moves the original code into its own function to help with readability, and adds a test to ensure the function tries to open and write files as expected.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11291
New Features
data-simulator submission_order --path <path here>, the code no longer will crash with a misleading message about the .txt file if the path does not existBreaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes